Fix example signing policy in salt.states.x509 docs #37135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @aaronm-cloudtek @clinta Does this look all right to you? |
cachedout
added
the
Pending-Discussion
|
Yes, that probably is a more appropriate key usage for a typical ssl certificate and is a better example. |
|
@clinta Thanks very much. @aaronm-cloudtek Thanks for this. I'll get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The example "www" signing policy has keyUsage set to "critical cRLSign, keyCertSign". These values are correct for a CA but not a SSL server certificate. With some SSL implementations this causes Firefox to throw SEC_ERROR_INADEQUATE_KEY_USAGE when the generated certificate is used on a web server. The correct value is "critical keyEncipherment".