Fix test hang #37175
Merged
Fix test hang #37175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to clean up here since the test suite will handle it for us.
s0undt3ch
approved these changes
Oct 24, 2016
| cls.process_manager.kill_children() | ||
| # Attempting to kill the children hangs the test suite. | ||
| # Let the test suite handle this instead. | ||
| # cls.process_manager.kill_children() | ||
| time.sleep(2) # Give the procs a chance to fully close before we stop the io_loop |
There was a problem hiding this comment.
The sleep is probably also unnecessary right?
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Oct 24, 2016
Merged
rallytime
pushed a commit
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to clean up here since the test suite will handle it for us. This unblocks the deployment of the newest version of salttesting.