Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding serializer extmod #46435

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Adding serializer extmod #46435

merged 2 commits into from
Mar 9, 2018

Conversation

onlyanegg
Copy link
Contributor

What does this PR do?

Adds the ability to use custom serializer modules through the external modules interface

What issues does this PR fix or reference?

#22257

Tests written?

Yes

Commits signed with GPG?

No

rallytime
rallytime suggested changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done - just a couple of small changes are needed here. :)

There's a lint error on this as well, but it's related to the versionadded line.

salt/modules/saltutil.py Outdated
@@ -737,6 +737,45 @@ def sync_utils(saltenv=None, refresh=True, extmod_whitelist=None, extmod_blackli
return ret


def sync_serializers(saltenv=None, refresh=True, extmod_whitelist=None, extmod_blacklist=None):
'''
.. versionadded:: ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fluorine :)

salt/runners/saltutil.py Outdated

def sync_serializers(saltenv='base', extmod_whitelist=None, extmod_blacklist=None):
'''
.. versionadded::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fluorine here, too.

@onlyanegg
Copy link
Contributor Author

Thanks, @rallytime! I added those changes.

@rallytime rallytime merged commit d6263a0 into saltstack:develop Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rallytime rallytime rallytime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onlyanegg @rallytime