Adding serializer extmod #46435
Merged
Adding serializer extmod #46435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Mar 8, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
Nicely done - just a couple of small changes are needed here. :)
There's a lint error on this as well, but it's related to the versionadded line.
salt/modules/saltutil.py
Outdated
|
|
||
| def sync_serializers(saltenv=None, refresh=True, extmod_whitelist=None, extmod_blacklist=None): | ||
| ''' | ||
| .. versionadded:: ? |
salt/runners/saltutil.py
Outdated
|
|
||
| def sync_serializers(saltenv='base', extmod_whitelist=None, extmod_blacklist=None): | ||
| ''' | ||
| .. versionadded:: |
Contributor
Author
|
Thanks, @rallytime! I added those changes. |
rallytime
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to use custom serializer modules through the external modules interface
What issues does this PR fix or reference?
#22257
Tests written?
Yes
Commits signed with GPG?
No