Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding serializer extmod #46435

Merged
merged 2 commits into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@onlyanegg
Copy link
Contributor

commented Mar 8, 2018

What does this PR do?

Adds the ability to use custom serializer modules through the external modules interface

What issues does this PR fix or reference?

#22257

Tests written?

Yes

Commits signed with GPG?

No

@rallytime
Copy link
Contributor

left a comment

Nicely done - just a couple of small changes are needed here. :)

There's a lint error on this as well, but it's related to the versionadded line.

@@ -737,6 +737,45 @@ def sync_utils(saltenv=None, refresh=True, extmod_whitelist=None, extmod_blackli
return ret


def sync_serializers(saltenv=None, refresh=True, extmod_whitelist=None, extmod_blacklist=None):
'''
.. versionadded:: ?

This comment has been minimized.

Copy link
@rallytime

rallytime Mar 8, 2018

Contributor

Fluorine :)


def sync_serializers(saltenv='base', extmod_whitelist=None, extmod_blacklist=None):
'''
.. versionadded::

This comment has been minimized.

Copy link
@rallytime

rallytime Mar 8, 2018

Contributor

Fluorine here, too.

@onlyanegg

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2018

Thanks, @rallytime! I added those changes.

@rallytime rallytime merged commit d6263a0 into saltstack:develop Mar 9, 2018

5 of 10 checks passed

default Build finished.
Details
jenkins/PR/salt-pr-linode-cent7-py3 Pull Requests » Salt PR - Linode CentOS 7 - PY3 #2987 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu14-n Pull Requests » Salt PR - Linode Ubuntu14.04 #20636 — FAILURE
Details
jenkins/PR/salt-pr-linode-ubuntu16-py3 Pull Requests » Salt PR - Linode Ubuntu16.04 - PY3 #7692 — FAILURE
Details
jenkins/PR/salt-pr-rs-cent7-n Pull Requests » Salt PR - RS CentOS 7 #17034 — FAILURE
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/PR/salt-pr-clone Pull Requests » Salt PR - Clone #23041 — SUCCESS
Details
jenkins/PR/salt-pr-docs-n Pull Requests » Salt PR - Docs #15356 — SUCCESS
Details
jenkins/PR/salt-pr-lint-n Pull Requests » Salt PR - Code Lint #19969 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.