Adding a merge_all function to slsutil#47679
Merged
Merged
Conversation
rallytime
reviewed
May 17, 2018
Contributor
There was a problem hiding this comment.
Can you add some more documentation to this new function? Each arg/kwarg should be documented.
Can you also add a ..versionadded:: Fluorine directive?
gtmanfred
approved these changes
May 18, 2018
cachedout
approved these changes
May 18, 2018
The merge_all function merges a list of objects in order. This will make it easier to merge more than two objects.
2c42d23 to
fc5ff22
Compare
Contributor
Author
|
Thanks @rallytime, @gtmanfred, @cachedout. I've added the versionadded tag and argument documentation. |
rallytime
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge_all function merges a list of objects in order. This will make merging multiple objects more readable. Consider the difference between merging three objects with
slsutil.mergeversus merging withslsutil.merge_allWith
slsutil.merge:With
slsutil.merge_all:I'm interested to know if you all think it would be better to add this function or to overload the merge function.
What does this PR do?
This PR adds a merge_all function to the slsutil module
What issues does this PR fix or reference?
None
Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.