Slack notice #49831

dubb-b · 2018-09-29T02:00:27Z

What does this PR do?

Adds slack notice to failed PR's in channel #jenkins-prod-pr

What issues does this PR fix or reference?

New Feature

Previous Behavior

None

New Behavior

Awesome notifications now!!!

Commits signed with GPG?

Yes

Fix docs formatting Clean up code Use explicit function calls Add comment about reboot status

Execution Module: - Passing no DNS servers will clear the list. - Update documentation - Added a note about clearing DNS entries State Module - An empty list in dns_servers will clear the entires - None in dns_servers will do nothing (default behavior) - Update Documentation

Add test=True support when clearing

Use named parameters where possible

The cache files used for these are based on the state's tag, so longer ID decs or names will cause errors when the filename's length exceeds the max allowed by the kernel. This fixes these errors by taking (up to) the first 32 chars of the result of base64-encoding the tag, and using that as the parallel cache filename.

The setUp only needs to run at the beginning so it can be a setUpClass, and the tearDown logic only applied to a single test and should not be run after each test.

The code works without this because at least one of the other modules being imported also imports this. But explicitly importing it here will keep us from getting bitten if the imports change elsewhere later on.

damon-atkins · 2018-09-29T04:42:17Z

Try this out, but you will need to write the code I assume. Given all tests need a working python you could use python to pull the info out of github.
https://api.github.com/repos/SaltStack/Salt/pulls/49831
Which will give you url for each reviewer "url": "https://api.github.com/users/gtmanfred",
Then in the message assume the github username and slack are the same and use @dubb-b in the slack message. But you might want to only include reviews when the tests past.

dubb-b · 2018-09-29T05:08:12Z

@damon-atkins Are you in community slack? If so hit me up, lets talk more about this. I am just trying to get a slack message for any PR that fails into a slack message so that we can start to identify them. But this is just a stop gap for now. We want to add some sort of TICK stack to Jenkins so that we get metrics on all builds, branch, PR etc.. Then we can group the data better. But I would love to hear any ideas you have. I've noticed you comment about this before. This process is one of our top priorities. And any feedback is welcome.

In your suggestion for improving this do you think adding more data is relevant? I could have a script that pulls the reviewer into the message. And quite a bit more if needed. @rallytime would this help at all?

I am checking out for the eve, although Monday feel free to hit me up.

Adding timeout to all pipelines so that the build aborts

Add ability to clear DNS entries on static DNS

rallytime · 2018-09-30T18:43:25Z

Then in the message assume the github username and slack are the same

We can't really assume that. There's lots of people who don't have the same GitHub and Slack usernames.

@dubb-b It seems here that you've got more commits in this than intended - this looks like you've got the stuff that has already been merged in here (i.e. the timeouts for docs/lint) rather than just the slack additions. Maybe this needs a rebase? It makes these kinds of changes a lot easier to review when the commit list is paired down to the relevant changes. :)

We can definitely chat more about this on Monday, but I think the general implementation is a great place to start.

Fix parallel states with long ID dec or name

gtmanfred

A few cosmetic changes.

gtmanfred · 2018-10-01T13:14:47Z

.ci/docs

@@ -45,6 +48,7 @@ pipeline {
                description: 'The docs job has failed',
                status: 'FAILURE',
                context: "jenkins/pr/docs"
+            slackSend (channel: "#jenkins-prod-pr", color: '#FF0000', message: "FAILED: PR-Job: '${env.JOB_NAME} [${env.BUILD_NUMBER}]' (${env.BUILD_URL})" + "\n It's not denial. I'm just selective about the reality I accept.")


this indent looks wrong.

A space here will cause the Sphinx role to treat whatever is after the comma as the comment for the directive, so it will be rendered with different CSS and look weird. Also, this fixes one syntactically incorrect versionadded which included a typo.

Fix badly formatted versionadded directive (2017.7 branch)

Use utf-8 encoding for salt-runtests.log

dubb-b · 2018-10-01T16:21:09Z

@rallytime This is odd, it grabbed all the other stuff as well. This is a new branch and all I wanted was the slack changes here. So i will close this and re-open a new one with the right commits.

gtmanfred · 2018-10-01T16:25:49Z

do a git pull --rebase origin 2017.7

rallytime

Once this is rebased I can review this.

Fixes #49836

Edit requisite documentation

This should actually cause builds to fail when any part in the try block fails. We still delete instances and try junit rendering, but if things fail then they get marked on github as failed.

Actually catch the exception when we fail

Better support for ec2 on laptops that also have vagrant installed.

Revert this after there is an upstream release

Gemfile updates

Populate changes dictionary on system.join_domain

Remove arrInstalled artifact

rallytime · 2018-10-05T13:48:57Z

@dubb-b Where are we with this one?

twangboy and others added 19 commits September 21, 2018 09:32

Populate changes dictionary

1f9bbc8

Fix docs formatting Clean up code Use explicit function calls Add comment about reboot status

Only clear dns entries if you pass []

5005a4d

Add test=True support when clearing

Add/fix tests

af1ed1c

Use named parameters where possible

Merge branch '2017.7' into fix_49730

defba1c

Merge branch '2017.7' into fix_49730

2cd1509

Remove/replace unnecessary setUp/tearDown

cb19086

The setUp only needs to run at the beginning so it can be a setUpClass, and the tearDown logic only applied to a single test and should not be run after each test.

Add additional info to the assert to aid in troubleshooting

5a11067

Skip parallel states test on Windows until we can get it to work

dca90d7

Explicitly import salt.utils.hashutils

0e26dc6

The code works without this because at least one of the other modules being imported also imports this. But explicitly importing it here will keep us from getting bitten if the imports change elsewhere later on.

Switch from base64 encoding to sha1 digest for unique cache filename

7ddfd72

Update test docstring to reflect switch to using SHA1

8a9945e

Adding timeout to all pipelines so that the build aborts

855ffe6

Updating syntax to be better and with new lines

f6d9679

Use utf-8 encoding for salt-runtests.log

7ce1b64

Fix broken tests, add new tests

7a9278b

Adding some changes for the status

b25ac9f

Adding slack notices for failed PRs

49a7d28

dubb-b requested review from gtmanfred and rallytime September 29, 2018 02:00

Nicole Thomas and others added 4 commits September 30, 2018 07:17

Merge pull request #49823 from dubb-b/timeout_addition

fd46d35

Adding timeout to all pipelines so that the build aborts

Merge branch '2017.7' into fix_49730

99bc8f1

Merge pull request #49763 from twangboy/fix_49730

98c9372

Add ability to clear DNS entries on static DNS

Merge branch '2017.7' into testslogencoding

2b323df

Nicole Thomas added 2 commits September 30, 2018 14:46

Merge pull request #49777 from terminalmage/issue49738

297031b

Fix parallel states with long ID dec or name

Merge branch '2017.7' into fix_49660

0a4f5fc

gtmanfred suggested changes Oct 1, 2018

View reviewed changes

terminalmage and others added 3 commits October 1, 2018 08:58

Merge pull request #49848 from terminalmage/fix-version-rst-2017.7

15ccffd

Fix badly formatted versionadded directive (2017.7 branch)

Merge pull request #49828 from dwoz/testslogencoding

0587fbc

Use utf-8 encoding for salt-runtests.log

rallytime reviewed Oct 1, 2018

View reviewed changes

Paulo-Nunes and others added 11 commits October 1, 2018 21:08

Edit requisite documentation

fb6f818

Fixes #49836

Merge branch '2017.7' into fix_49660

f3400ad

Merge pull request #49858 from Paulo-Nunes/fix-requisite-doc

7fa2043

Edit requisite documentation

Actually catch the exception when we fail

9ef9206

This should actually cause builds to fail when any part in the try block fails. We still delete instances and try junit rendering, but if things fail then they get marked on github as failed.

Merge pull request #49870 from KaiSforza/ci_actually_fail

0662e37

Actually catch the exception when we fail

Move vagrant to it's own group

f3999e1

Better support for ec2 on laptops that also have vagrant installed.

Use dwoz/winrm-fs for chunked downloads

791e3ff

Revert this after there is an upstream release

Merge pull request #49885 from dwoz/gemfile

71669bd

Gemfile updates

Merge pull request #49739 from twangboy/fix_49660

b959033

Populate changes dictionary on system.join_domain

Remove arrInstalled artifact

a66765f

Merge pull request #49899 from twangboy/fix_49892

8c4707d

Remove arrInstalled artifact

Brett Benassi added 2 commits October 5, 2018 08:33

Updating formatting and the message

e0a87cf

Updating Merege conflict

1708bc4

dubb-b closed this Oct 5, 2018

rallytime mentioned this pull request Oct 5, 2018

Adding failure messages for PR. #49911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Slack notice #49831

Slack notice #49831

dubb-b commented Sep 29, 2018

damon-atkins commented Sep 29, 2018 •

edited

Loading

dubb-b commented Sep 29, 2018

rallytime commented Sep 30, 2018 •

edited

Loading

gtmanfred left a comment

gtmanfred Oct 1, 2018

dubb-b commented Oct 1, 2018

gtmanfred commented Oct 1, 2018

rallytime left a comment

rallytime commented Oct 5, 2018

Slack notice #49831

Slack notice #49831

Conversation

dubb-b commented Sep 29, 2018

What does this PR do?

What issues does this PR fix or reference?

Previous Behavior

New Behavior

Commits signed with GPG?

damon-atkins commented Sep 29, 2018 • edited Loading

dubb-b commented Sep 29, 2018

rallytime commented Sep 30, 2018 • edited Loading

gtmanfred left a comment

Choose a reason for hiding this comment

gtmanfred Oct 1, 2018

Choose a reason for hiding this comment

dubb-b commented Oct 1, 2018

gtmanfred commented Oct 1, 2018

rallytime left a comment

Choose a reason for hiding this comment

rallytime commented Oct 5, 2018

damon-atkins commented Sep 29, 2018 •

edited

Loading

rallytime commented Sep 30, 2018 •

edited

Loading