Remove deprecated bits for Sodium in virt #56414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
354005b
to
53b39cd
Compare
DmitryKuzmenko
suggested changes
Mar 19, 2020
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
53b39cd
to
37c331c
Compare
|
@DmitryKuzmenko answered your question and rebased on master |
DmitryKuzmenko
previously approved these changes
Apr 2, 2020
|
@cbosdo could you please resolve merge conflicts? |
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
37c331c
to
71ee09d
Compare
|
rebased |
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
71ee09d
to
23feca4
Compare
DmitryKuzmenko
previously approved these changes
Apr 7, 2020
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
23feca4
to
43bbf3c
Compare
|
@cbosdo black needs to be run on this. |
|
OK, I'll rerun it on Tuesday morning |
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
4f9c388
to
61640bd
Compare
ElementTree.tostring() implementation starts to keep the attribute order defined by the user in python 3.8. This can lead to equal elements to be considered different. Use xmlutil.to_dict(element, True) to compare the elements. This also uncovered a wrong behavior of pool_update when only changing the password.
cbosdo
force-pushed
the
virt-na-deprecated-removal
branch
from
61640bd
to
e90e78d
Compare
|
rebased on latest master. @dwoz could that one be merged since there is only the codecov check that is red for some weird reason? |
|
There was also a windows failure - yeah, at this point I re-started the windows2016 job - failures didn't look |
|
@waynew the windows test went green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes all the deprecated parameters, configuration and functions that are to be removed in Sodium for the virt module.
What issues does this PR fix or reference?
Tests written?
Yes: tests adapted where needed
Commits signed with GPG?
Yes