-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues after CVE fixes #59664
Fix some issues after CVE fixes #59664
Conversation
@dwoz here you have it 👍 |
ce6b06d
to
a412bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures on windows were introduced in this PR and look valid.
Hey @s0undt3ch, the previously failing test for windows is a new test I've just introduced with this PR - it was not an existing one. I've skipped it on Windows since it seems doesn't like calling Do you want this test to be also implemented to run on Windows? |
Yes, I explained myself incorrectly :) |
@s0undt3ch I've fixed the test for Windows. I see now some other failures for "windows2019" and "macosxcatalina" after rebasing with master, but I think they're not related to this PR. |
What does this PR do?
We've detected few issues after February CVE fixes:
extra_filerefs
parameter is discarded for the SSHClientcmd.run
function crashes if passing tuple arg:This PR fixes these issues.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.