-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for multicast entries ipv6 routes on Linux #59829
Conversation
…s/network.py Patrial fix (only for multicast entries for now) for saltstack#58377
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require test coverage and a changelog file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
Here is the output of my test:
root@omv6box:/home/vagrant# ip -6 route show table all
::1 dev lo proto kernel metric 256 pref medium
fe80::/64 dev ens6 proto kernel metric 256 pref medium
fe80::/64 dev ens8 proto kernel metric 256 pref medium
local ::1 dev lo table local proto kernel metric 0 pref medium
local fe80::5054:ff:fe27:25a6 dev ens8 table local proto kernel metric 0 pref medium
local fe80::5054:ff:fe58:56f dev ens6 table local proto kernel metric 0 pref medium
multicast ff00::/8 dev ens6 table local proto kernel metric 256 pref medium
multicast ff00::/8 dev ens8 table local proto kernel metric 256 pref medium
root@omv6box:/home/vagrant#
root@omv6box:/home/vagrant#
root@omv6box:/home/vagrant# salt-call --local --retcode-passthrough --no-color --out=json network.routes inet6
{
"local": [
{
"addr_family": "inet6",
"destination": "::1",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "lo"
},
{
"addr_family": "inet6",
"destination": "fe80::/64",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "ens6"
},
{
"addr_family": "inet6",
"destination": "fe80::/64",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "ens8"
},
{
"addr_family": "inet6",
"destination": "::1/128",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "lo"
},
{
"addr_family": "inet6",
"destination": "fe80::5054:ff:fe27:25a6/128",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "ens8"
},
{
"addr_family": "inet6",
"destination": "fe80::5054:ff:fe58:56f/128",
"gateway": "::",
"netmask": "",
"flags": "U",
"interface": "ens6"
},
{
"addr_family": "inet6",
"destination": "ff00::/8",
"gateway": "table",
"netmask": "",
"flags": "U",
"interface": "ens6"
},
{
"addr_family": "inet6",
"destination": "ff00::/8",
"gateway": "table",
"netmask": "",
"flags": "U",
"interface": "ens8"
}
]
}
We will need a test added to our test suite, to ensure this does not regress in the future. Here is some documentation on our test suite and how to get started: https://docs.saltproject.io/en/latest/topics/tutorials/writing_tests.html And here is documentation on how to add a changelog file: https://docs.saltproject.io/en/latest/topics/development/changelog.html |
The issue has been resolved for 3004, see https://github.com/saltstack/salt/blob/v3004/salt/modules/network.py#L574. |
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
What does this PR do?
Add processing for multicast entries in ip -6 route show table all output
What issues does this PR fix or reference?
Patrial fix (only for multicast entries for now) for #58377
Previous Behavior
backtrace whan network.routes used on LInux without netstat
New Behavior
correct ipv6 route entry in network.routes
Commits signed with GPG?
No