Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipc_write_buffer to master/minion config docs #62846

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add ipc_write_buffer to master/minion config docs #62846

merged 1 commit into from
Oct 10, 2022

Conversation

auria
Copy link
Contributor

@auria auria commented Oct 10, 2022

This option was introduced in 2016 [1] and typing enforced in 2022 [2]. However, documentation was not added in the master and minion configuration docs. This change adds the mentioned documentation.

  1. Fix publisher leak #34683
  2. ea35cb5

Fixes: #62842

Commits signed with GPG?

Yes

@auria
Add ipc_write_buffer to master/minion config docs
b24826a 
This option was introduced in 2016 [1] and typing enforced in 2022 [2].
However, documentation was not added in the master and minion
configuration docs. This change adds the mentioned documentation.

1. saltstack#34683
2. saltstack@ea35cb5
@auria auria requested a review from a team as a code owner October 10, 2022 12:27
@auria auria requested review from twangboy and removed request for a team October 10, 2022 12:27
@welcome
Copy link

welcome bot commented Oct 10, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

barbaricyawps
barbaricyawps approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@barbaricyawps barbaricyawps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me from a communication standpoint. I'll want an engineer to verify the technical accuracy.

@Ch3LL Ch3LL merged commit 50dd3ff into saltstack:master Oct 10, 2022
@welcome
Copy link

welcome bot commented Oct 10, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaricyawps barbaricyawps barbaricyawps approved these changes

@dmurphy18 dmurphy18 dmurphy18 approved these changes

@twangboy twangboy Awaiting requested review from twangboy twangboy was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] ipc_write_buffer missed in master config doc
4 participants
@auria @dmurphy18 @barbaricyawps @Ch3LL