Cleanup PAexec on disconnect #63031
Merged
Cleanup PAexec on disconnect #63031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
requested review from
garethgreenaway
and removed request for
a team
Ch3LL
approved these changes
Nov 16, 2022
MKLeb
approved these changes
Nov 16, 2022
whytewolf
approved these changes
Nov 16, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempts to use the cleanup() function of the pypsexec client to clean up binaries on disconnect.
Wayne and I verified that the
cleanup()function does in fact clean up any lingering PAexe-*.exe files in the Windows directory.What issues does this PR fix or reference?
Fixes: #62152
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes