Explicity pass context for salt-ssh state calls#63184
Merged
Merged
Conversation
This was referenced Dec 2, 2022
Ch3LL
changed the title
Ch3LL
changed the title
3 tasks
Rudd-O
previously approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Whoa this looks nice. Honestly, the functions being called should have never gained optional context parameters — that pattern was always a recipe that introduced fragility for maintainers and hid code smells. Hoping that Salt code will gain some type checking soon, to make these problems easier to solve.
Please ensure that your PR complies with the stated requirements for merging — including but not limited to fixing the testing. Thanks.
Ch3LL
force-pushed
the
ssh_map
branch
2 times, most recently
from
e8148dc to
13afb21
Compare
cmcmarrow
previously approved these changes
Dec 6, 2022
cmcmarrow
approved these changes
Dec 7, 2022
cmcmarrow
left a comment
cmcmarrow
left a comment
Contributor
There was a problem hiding this comment.
Should probably get the commits signing again.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60003