-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Fix 64260: Remove isfile
check to increase speed of listing large numbers of keys
#64262
Conversation
Looks good, but I would also like to get @dwoz 's review here |
ab26ef1
to
5bf9c1d
Compare
I'm not sure I agree with adding an option for this. I think it would make sense to have this (not checking |
…eys on slow file storage
791342b
to
c052471
Compare
What does this PR do?
It adds a configuration option for skipping the
isfile
check when enumerating keys in various situations. This speeds up minion key listing significantly in certain situations.What issues does this PR fix or reference?
Fixes: #64260
Previous Behavior
Minion key listing and salt master startup took minutes with 10k+ minions and key storage on a slow filesystem (e.g. NAS).
New Behavior
Minion key listing is performant.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No