Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fixed incorrect version argument will be ignored warning #66388

Merged
merged 1 commit into from
May 13, 2024

Conversation

bdrx312
Copy link
Contributor

@bdrx312 bdrx312 commented Apr 18, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes: #64563

Previous Behavior

Prints [WARNING ] 'version' argument will be ignored for multiple package targets when pkgs argument is used to pkg.installed on systems with yum/dnf.

New Behavior

No longer prints the warning.

Merge requirements satisfied?

Commits signed with GPG?

No

@bdrx312 bdrx312 requested a review from a team as a code owner April 18, 2024 01:14
@bdrx312 bdrx312 requested review from twangboy and removed request for a team April 18, 2024 01:14
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fixed incorrect version argument will be ignored warning [master] Fixed incorrect version argument will be ignored warning Apr 18, 2024
@twangboy
Copy link
Contributor

Could we get a test for this please?

@bdrx312
Copy link
Contributor Author

bdrx312 commented Apr 29, 2024

Could we get a test for this please?

Added

@bdrx312
Copy link
Contributor Author

bdrx312 commented May 11, 2024

Is there a estimate on what release and when this can get merged?

@dwoz dwoz merged commit 00f6d42 into saltstack:master May 13, 2024
194 checks passed
@bdrx312 bdrx312 deleted the fix_pkg_install_warning branch May 13, 2024 23:43
@hurzhurz
Copy link
Contributor

@dwoz will this find its way into the 3006.x branch (and the next release), too?

It should also solve my issue #64476, where I currently use a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pkg.installed state with pkgs argument but no version gives WARNING
4 participants