[master] Second salt con #66635
Open
[master] Second salt con #66635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
…g entry - Replace print statements with logging using log for consistency - Add specific exception handling for ClientError, NoCredentialsError, and PartialCredentialsError - Update the changelog to document the changes - Create tests for logging using caplog to ensure proper logging behavior
Akm0d
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances error handling and logging in the
tools/utils/repo.pymodule. It also adds corresponding tests and updates the changelog.Changes
logfor consistency.ClientError,NoCredentialsError, andPartialCredentialsError.CHANGELOG.mdto document these changes.tests/test_repo.pyto add tests for the logging functionality usingcaplog.Testing
get_repo_json_file_contentsfunction handles different exceptions correctly and logs appropriate messages.caplogto check that logging occurs as expected during different scenarios.Additional Notes
These changes aim to improve the robustness and maintainability of the code, making it easier to debug and understand. The logging ensures that detailed information is available when issues arise, facilitating quicker resolution.