[3006.x] Update to include croniter in pkg requirements #66644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
added
dependency
salt-project-bot-prod-environment
bot
changed the title
dwoz
changed the title
dwoz
previously approved these changes
Jun 18, 2024
dmurphy18
changed the title
Akm0d
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds croniter to packing for Salt, since used in salt/utils/scheduler, but outputs error to log if the user has not installed it, which seems a complete hassle to use a scheduler which is not fully supported.
What issues does this PR fix or reference?
Fixes #57649
Previous Behavior
User had to salt-pip install croniter to utilize full capabilities of scheduler.
New Behavior
croniter is available by default to utilize full capabilities of scheduler.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.