Add Codex #237
Add Codex #237
Conversation
|
don't approve yet, not sure if I'm having trouble due to not setting up my user in the UI or if its something else. :p works fine via compose, need to dick w the role for a few |
|
Ok, it works as expected now. Pulls up paths and allows you to scan your comics directory. |
|
Awesome. Thank you for your efforts. Much appreciated. |
Happy to help! Just gotta wait for someone to review it and make sure its ok with the maintainers and it will go live. : ) |
|
Did you check if it HAS to be |
|
I'll take another quick look. just a sec |
|
I didn't look too deep into it as I'm in bed rn, but this is the compose from their "docker" setup on docker hub: services:
codex:
env_file: .env
image: docker.io/ajslater/codex
container_name: codex
volumes:
- <host path to data>:/config
- <host path to comics>:/comics:ro
ports:
- 9810:9810
restart: on-failure |
|
|
|
Might be too late and my brain isn't processing the question correctly. when you ask if it needs to be mapped to |
|
Yeh, so I think I would add /mnt:/mnt to this so people can also use whatever library paths they want or might already have. Also need to think about how we add this to the traefik branch at the same time, so don't delete the branch after it gets merged, put in another PR for the traefik3 branch and we can edit it to work there as well. We should check we are still adding mnt:/mnt and not /mnt/Media for this sort of situation too. There is of course the custom inventory option too. |
I can change that up, no prob. Should I go around and change the other sandbox roles w the full path on them? Maybe not, since it could screw up how it’s currently configured? |
Remove full “Media” path from `paths`. Changed full “Media” path mapping (docker volumes) to /mnt. Removed /comics volume.
trigger ci
remove /mnt
|
I was scratching my head looking for the default docker volume with |
|
I was actually under the impression that /mnt:/mnt had been removed and was frowned upon being added to all roles so I too was scratching. |
|
We just added an opt-out variable from what I remember
…On Tue, 27 Jun 2023, 00:52 Max Kowalski, ***@***.***> wrote:
I was actually under the impression that /mnt:/mnt had been removed and
was frowned upon being added to all roles so I too was scratching.
—
Reply to this email directly, view it on GitHub
<#237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSIMLVRUPLM4VA4YDOJ5FTXNIHBTANCNFSM6AAAAAAWECZNXE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I think I did this without thinking :p |
|
Are we all good with this one now RD? And we have a docs PR too? |
|
hmm I'll have to see if I've made that already or not. I'll take a look. It shouldn't be too difficult to get done. : ) but yes all set on this one! Aside from the docs PR
|
|
@maximuskowalski @owine review this before the end of the weekend, merge it to traefik3 or close it. |
* Add Codex, def and tasks, add to sandbox.yml * Corrected envs PUID & PGID * Update main.yml Remove full “Media” path from `paths`. Changed full “Media” path mapping (docker volumes) to /mnt. Removed /comics volume. * Update main.yml trigger ci * Update main.yml remove /mnt --------- Co-authored-by: Max Kowalski <13492750+maximuskowalski@users.noreply.github.com>
|
This was merged without a direct test - any issues with the role, please ping me in Discord to troubleshoot |
Description
Adding Codex, as recently requested. It adds the volume,
/comicsto/mnt/unionfs/Media/Comicsas currently written.How Has This Been Tested?
Installed via docker compose initially, then installed via saltbox_mod. That is how I'm currently running it. Works fine and I've not gotten any errors so far. the user mapping seems to be working fine, and its still scanning my comic directory.