ci: add react-18 to tests #194

Yeti-or · 2022-10-20T11:06:28Z

Реакт полностью переключен на 18 версию
Storybook теперь на react 18
Cypress + jest гоняются на двух версиях: 18 & 17

--
отключен стаб для Editable:selectText

🐤 Download canary assets:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-b2c@1.152.2-canary.194.4342208887.0
npm install @salutejs/plasma-core@1.100.2-canary.194.4342208887.0
npm install @salutejs/plasma-hope@0.11.2-canary.194.4342208887.0
npm install @salutejs/plasma-icons@1.128.2-canary.194.4342208887.0
npm install @salutejs/plasma-temple@1.139.2-canary.194.4342208887.0
npm install @salutejs/plasma-tokens@1.38.1-canary.194.4342208887.0
npm install @salutejs/plasma-typo@0.31.1-canary.194.4342208887.0
npm install @salutejs/plasma-ui@1.172.2-canary.194.4342208887.0
npm install @salutejs/plasma-web@1.177.2-canary.194.4342208887.0
npm install @salutejs/plasma-cy-utils@0.45.1-canary.194.4342208887.0
npm install @salutejs/plasma-sb-utils@0.98.2-canary.194.4342208887.0
npm install @salutejs/plasma-tokens-android@2.45.1-canary.194.4342208887.0
npm install @salutejs/plasma-tokens-ios-swift@2.45.1-canary.194.4342208887.0
# or 
yarn add @salutejs/plasma-b2c@1.152.2-canary.194.4342208887.0
yarn add @salutejs/plasma-core@1.100.2-canary.194.4342208887.0
yarn add @salutejs/plasma-hope@0.11.2-canary.194.4342208887.0
yarn add @salutejs/plasma-icons@1.128.2-canary.194.4342208887.0
yarn add @salutejs/plasma-temple@1.139.2-canary.194.4342208887.0
yarn add @salutejs/plasma-tokens@1.38.1-canary.194.4342208887.0
yarn add @salutejs/plasma-typo@0.31.1-canary.194.4342208887.0
yarn add @salutejs/plasma-ui@1.172.2-canary.194.4342208887.0
yarn add @salutejs/plasma-web@1.177.2-canary.194.4342208887.0
yarn add @salutejs/plasma-cy-utils@0.45.1-canary.194.4342208887.0
yarn add @salutejs/plasma-sb-utils@0.98.2-canary.194.4342208887.0
yarn add @salutejs/plasma-tokens-android@2.45.1-canary.194.4342208887.0
yarn add @salutejs/plasma-tokens-ios-swift@2.45.1-canary.194.4342208887.0

Salute-Eva · 2022-10-27T18:48:16Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-194/
ui storybook: http://plasma.sberdevices.ru/pr-194/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-194/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-194/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-194/temple-storybook/

Salute-Eva · 2023-02-15T07:24:13Z

Component performance testing

Result: 🌚 Missing base report

Check out current report in job artifacts!

Salute-Eva · 2023-02-15T07:25:48Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-194/

Salute-Eva · 2023-02-27T08:15:21Z

Component performance testing

Result: 🌚 Missing base report

Check out current report in job artifacts!

Salute-Eva · 2023-02-27T08:15:44Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-194/

Salute-Eva · 2023-02-27T08:25:28Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-194/

Salute-Eva · 2023-02-27T08:27:00Z

Component performance testing

Result: 🌚 Missing base report

Check out current report in job artifacts!

Salute-Eva · 2023-03-03T15:03:19Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-194/

Salute-Eva · 2023-03-03T15:22:43Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-194/
ui storybook: http://plasma.sberdevices.ru/pr/pr-194/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-194/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-194/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-194/temple-storybook/

neretin-trike · 2023-03-06T09:26:47Z

добавишь небольшое описание? Про то что, тесты добавил, версию реакта переключил и т.д.

neretin-trike · 2023-03-06T09:49:30Z

.github/workflows/cypress-ct-17.yml

+        npm i
+        npm i react@17 react-dom@17 --prefix="./packages/plasma-ui"
+        npm i react@17 react-dom@17 --prefix="./packages/plasma-temple"
+        npm i react@17 react-dom@17 --prefix="./packages/plasma-hope"


такс, а тут не надо ещё npm i react@17 react-dom@17 --prefix="./packages/plasma-core"? Там же тоже реакт имеется, и зависимые компоненты

я решил что можно оставить только конечные пакеты чтобы оно быстрее ставилось, в плане реакт же резолвится там где испоняются тесты, думаю что кстати plasm-hope можно тоже удалить тут

neretin-trike · 2023-03-06T09:54:10Z

.github/workflows/tests-17.yml

+          npm i
+          npm i react@17 react-dom@17 --prefix="./packages/plasma-ui"
+          npm i react@17 react-dom@17 --prefix="./packages/plasma-temple"
+          npm i react@17 react-dom@17 --prefix="./packages/plasma-hope"


а тут нужен plasma-core?

packages/plasma-core/api/plasma-core.api.md

build(plasma-ui): pin @types/express-serve-static-core check issue: DefinitelyTyped/DefinitelyTyped#53397

Salute-Eva · 2023-03-06T10:09:56Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-194/

Salute-Eva · 2023-03-06T10:22:45Z

Component performance testing

Result: 💀 Missing report, something went wrong

Check out current report in job artifacts!

Salute-Eva · 2023-03-06T10:25:37Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/pr/demo-canvas-app-pr-194/

Salute-Eva · 2023-03-06T10:29:15Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-194/
ui storybook: http://plasma.sberdevices.ru/pr/pr-194/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-194/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-194/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-194/temple-storybook/

Yeti-or requested review from neretin-trike and Yakutoc as code owners October 20, 2022 11:06

Yeti-or force-pushed the yeti-or.react-18 branch 3 times, most recently from ed5fc2e to 1d39a58 Compare October 27, 2022 07:51

Yeti-or requested a review from LamaEats as a code owner October 27, 2022 11:39

Yeti-or force-pushed the yeti-or.react-18 branch 2 times, most recently from e7a2d2a to 4436c51 Compare October 27, 2022 17:28

salute-developers deleted a comment from Salute-Eva Oct 27, 2022

Yeti-or force-pushed the yeti-or.react-18 branch 2 times, most recently from 839c364 to de033d2 Compare October 27, 2022 18:27

Yeti-or force-pushed the yeti-or.react-18 branch 4 times, most recently from aaf2e78 to 0f362ad Compare November 24, 2022 13:04

akhdrv mentioned this pull request Nov 28, 2022

fix(plasma-ui): fix using sb-addon-performance usages for future storybook versions #248

Merged

Yeti-or force-pushed the yeti-or.react-18 branch from 0f362ad to bd4a84f Compare November 28, 2022 16:56

Yeti-or force-pushed the yeti-or.react-18 branch 2 times, most recently from f527b6d to 4446fed Compare December 14, 2022 12:30

Yeti-or force-pushed the yeti-or.react-18 branch from 4446fed to 2f61101 Compare February 15, 2023 07:21

Yeti-or force-pushed the yeti-or.react-18 branch from 2f61101 to a234dbb Compare February 27, 2023 08:12

Yeti-or force-pushed the yeti-or.react-18 branch from a234dbb to 7c2c803 Compare February 27, 2023 08:22

Yakutoc approved these changes Mar 6, 2023

View reviewed changes

neretin-trike reviewed Mar 6, 2023

View reviewed changes

packages/plasma-core/api/plasma-core.api.md Show resolved Hide resolved

Yeti-or added 15 commits March 6, 2023 13:05

ci: add react-18 to tests

689eeb9

build(plasma-ui): bump react to 18x

76f61ba

build(plasma-ui): pin @types/express-serve-static-core check issue: DefinitelyTyped/DefinitelyTyped#53397

build(plasma-core): bump react to 18 version

5012d15

build(plasma-cy-utils): bump react to 18x

0192e11

build(plasma-temple): bump react to 18.x

1644877

build(plasma-icons): bump react to 18x

b446a18

build(plasma-b2c): bump react to 18.x

6d58f63

build(plasma-typo): bump react to 18x

39f1b63

build(plasma-sb-utils): bump react to 18x

e35da83

build(plasma-web): bump react to 18x

115cae6

build(plasma-docs-ui): bump react to 18x

3369988

build(plasma-hope): bump react to 18x

9941432

build(plasma-hope): bump react to 18x

9fe61aa

build(plasma-hope): update API diff

4d275ce

test(plasma-hope): disable stub

e8331d8

Yeti-or force-pushed the yeti-or.react-18 branch from 70fa4e9 to e8331d8 Compare March 6, 2023 10:06

neretin-trike approved these changes Mar 6, 2023

View reviewed changes

Yeti-or merged commit 840877d into master Mar 6, 2023

Yeti-or deleted the yeti-or.react-18 branch March 6, 2023 11:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add react-18 to tests #194

ci: add react-18 to tests #194

Yeti-or commented Oct 20, 2022 •

edited by Salute-Eva

Loading

Salute-Eva commented Oct 27, 2022

Salute-Eva commented Feb 15, 2023

Salute-Eva commented Feb 15, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Mar 3, 2023

Salute-Eva commented Mar 3, 2023

neretin-trike commented Mar 6, 2023

neretin-trike Mar 6, 2023

Yeti-or Mar 6, 2023

neretin-trike Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

ci: add react-18 to tests #194

ci: add react-18 to tests #194

Conversation

Yeti-or commented Oct 20, 2022 • edited by Salute-Eva Loading

Salute-Eva commented Oct 27, 2022

Salute-Eva commented Feb 15, 2023

Salute-Eva commented Feb 15, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Feb 27, 2023

Salute-Eva commented Mar 3, 2023

Salute-Eva commented Mar 3, 2023

neretin-trike commented Mar 6, 2023

neretin-trike Mar 6, 2023

Choose a reason for hiding this comment

Yeti-or Mar 6, 2023

Choose a reason for hiding this comment

neretin-trike Mar 6, 2023

Choose a reason for hiding this comment

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Salute-Eva commented Mar 6, 2023

Yeti-or commented Oct 20, 2022 •

edited by Salute-Eva

Loading