Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish up the code #2

Open
sam46 opened this issue Oct 1, 2018 · 4 comments
Open

Polish up the code #2

sam46 opened this issue Oct 1, 2018 · 4 comments

Comments

@sam46
Copy link
Owner

sam46 commented Oct 1, 2018

No description provided.

elacheche added a commit to elacheche/Morph that referenced this issue Oct 1, 2018
@elacheche
Best wat to fix sam46#2 is to drop Python2 and migrate to Python3
48f775c
@elacheche elacheche mentioned this issue Oct 1, 2018
Closed
@shubhammatta
Copy link

@sam46 I can work on the script. But can you be a bit more clear on what do you want in regards to polishing up the code.Script looks fine to me

@sam46
Copy link
Owner Author

sam46 commented Oct 1, 2018 •
edited
Loading

@shubhammatta well the code (e.g. effect/transformations) is not so reusable and
even has so much duplicate code in it.

@thomasstep
Copy link

I can look into refactoring if that's what you mean

@sam46
Copy link
Owner Author

sam46 commented Oct 1, 2018 •
edited
Loading

@shubhammatta
this... the effects can be grouped into useful functions like rotation, fuzzing and such.
Yeah refactoring basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Py3port elacheche/Morph
3 participants
@shubhammatta @sam46 @thomasstep