-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes added to VideoBg tag #2
Comments
The other thing, is it possible to make the poster show after the video has played? |
This is not supported, Planing to implement this soon :) |
I have done a silly mistake in proptype validation in https://github.com/samAbeywickrama/reactjs-videobg/blob/master/src/VideoBg.js 😅
It has to be
I will add a fix to this and do a release asap :) |
Changed string proptype to boolean Closes: #2
🎉 This issue has been resolved in version 1.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Working on this here #4 |
Solid! |
You da champ! Thank you. |
How am i to add attributes to this tag.
i currently have such:
<VideoBg loop={false} muted={false} poster={...}>
I am getting the warning fro both
'Failed prop type: Invalid prop
loop
of typeboolean
supplied toj
, expectedstring
.The text was updated successfully, but these errors were encountered: