-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add Montenegro #125
Comments
@neacsugeorge I will add it, thanks for the info. If you want, you can also send a PR and I will merge it. |
Made the changes and created a pull request #136 |
I will add this, thanks for the contribution. However, in-order to add it, I must also include an entry to all the other files (population, iso-codes, flags) otherwise the list of countries in all files will be out of sync. I will add you PR in the next major version. Thanks for your contribution |
@samayo should I add the entry to the other files? |
Yes, that would be very helpful |
hi @samayo Also, reopen the issue if you can so that I can assign it to myself. Thanks |
Hi Kidilowski, I have reopened the issue. Thanks for the contribution. The Geo-coordinates is just the latitude/longitude for the country, which is: 42.7087° N, 19.3744° E (you can google it) I see only some files have changed but all of them need to have the country and value, I will check from my laptop later and the flag is ok. Thanks, I will check and get back to you As for the PR |
Hi @samayo |
Thanks. For now use the North and East, then I will review all the changes and merge them |
Done 👍 |
@kidilowski Thanks for your help a lot!!! I have merged it to master, and I will tag a new release soon |
I received a request to add Montenegro (+382) as a country in country-by-calling-code.json. Thank you.
The text was updated successfully, but these errors were encountered: