Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Montenegro #125

Closed
neacsugeorge opened this issue Nov 10, 2019 · 11 comments
Closed

Please add Montenegro #125

neacsugeorge opened this issue Nov 10, 2019 · 11 comments

Comments

@neacsugeorge
Copy link

neacsugeorge commented Nov 10, 2019

I received a request to add Montenegro (+382) as a country in country-by-calling-code.json. Thank you.

@samayo
Copy link
Owner

samayo commented Nov 10, 2019

@neacsugeorge I will add it, thanks for the info. If you want, you can also send a PR and I will merge it.

@a1764879
Copy link
Contributor

Made the changes and created a pull request #136

@samayo
Copy link
Owner

samayo commented Mar 5, 2020

I will add this, thanks for the contribution. However, in-order to add it, I must also include an entry to all the other files (population, iso-codes, flags) otherwise the list of countries in all files will be out of sync. I will add you PR in the next major version.

Thanks for your contribution

@samayo samayo closed this as completed Mar 5, 2020
@a1764879
Copy link
Contributor

a1764879 commented Apr 7, 2020

@samayo should I add the entry to the other files?
Montenegro in (population, iso-codes, flags) ?

@samayo
Copy link
Owner

samayo commented Apr 7, 2020

Yes, that would be very helpful

@a1764879
Copy link
Contributor

a1764879 commented Apr 16, 2020

hi @samayo
I'll be giving a pull request shortly.
For the flag, I've used https://base64.guru/converter/encode/image/svg to convert the SVG to the base64, could you just make sure it's correct?
Also, I didn't quite understand the info to be added in the geo-cordinates.json, so if you tell me from where to get those, I'll do that as well

Also, reopen the issue if you can so that I can assign it to myself. Thanks

@samayo samayo reopened this Apr 16, 2020
@samayo
Copy link
Owner

samayo commented Apr 16, 2020

Hi Kidilowski, I have reopened the issue. Thanks for the contribution. The Geo-coordinates is just the latitude/longitude for the country, which is: 42.7087° N, 19.3744° E (you can google it) I see only some files have changed but all of them need to have the country and value, I will check from my laptop later and the flag is ok.

Thanks, I will check and get back to you

As for the PR

@a1764879
Copy link
Contributor

Hi @samayo
I did check for the coordinates, but in the JSON file, it is given as:
{ "country": "Afghanistan", "north": "38.4834", "south": "29.3775", "west": "60.4784", "east": "74.8794" }
From the NE values from google, we will get just two values.
Also, I will check if there are any files with the country name to be updated. Some of them already had Montenegro in it.

@samayo
Copy link
Owner

samayo commented Apr 16, 2020

Thanks. For now use the North and East, then I will review all the changes and merge them

@a1764879
Copy link
Contributor

Done 👍

samayo added a commit that referenced this issue Apr 16, 2020
@samayo
Copy link
Owner

samayo commented Apr 16, 2020

@kidilowski Thanks for your help a lot!!! I have merged it to master, and I will tag a new release soon

@samayo samayo closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants