Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitlint support to samba-container #124

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Add gitlint support to samba-container #124

merged 5 commits into from
Apr 21, 2023

Commits on Apr 20, 2023

  1. makefile: add check-gitlint rule for checking commits 

    The rule `check-gitlint` can be run in order to see if commits on the
current branch meet the basic requirements for the project.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    88b5dbf View commit details
    Browse the repository at this point in the history

  2. workflows: add a check-commits job 

    The check-commits job will help validate the commit messages on the
commits included in a PR.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bcd7101 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. hack: add a install-tools.sh script for locally installing certain tools 

    This is similar, and inspired by, but not the same as, the
install-tools.sh in samba-operator repo.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7d27175 View commit details
    Browse the repository at this point in the history

  2. makefile: add support for install-tools.sh fetching tools 

    I don't really like this but it matches the behavior of samba-operator
while at the same time uses pattern matching so that future tools do not
need a lot of boilerplate in the makefile for each instance.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a156864 View commit details
    Browse the repository at this point in the history

  3. workflows: now we can install directly via make/install-tools.sh use it 

    Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a604d36 View commit details
    Browse the repository at this point in the history