Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade to newer versions #307

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

synarete
Copy link
Collaborator

@synarete synarete commented May 17, 2023

Upgrade logr, client-go and controller-runtime to newer versions which include various bug fixes. Align code with respect to changes in those libraries.

depends on #310

@phlogistonjohn
Copy link
Collaborator

Thanks! This has been on my TODO list for a while so I'm happy to see this happen.
On quick skim most things look OK, but since it is a big commit I will need a bit more time to fully review.

@phlogistonjohn
Copy link
Collaborator

Commit message nitpick: change upgrade to newer versions to update packages to newer versions. That way we're clarify that it's not a bump of the required go version, but impacts the dependencies.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick, nothing major

internal/resources/util_fakes_test.go Outdated Show resolved Hide resolved
@mergify mergify bot added the priority-review This PR deserves a look label Jun 7, 2023
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Never hesitate to ping me if I ask for something and then you don't hear back from me for a while. :-)

@phlogistonjohn
Copy link
Collaborator

@obnoxxx @spuiuk 2nd review please?

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jun 20, 2023

rebase

✅ Branch has been successfully rebased

@dpulls
Copy link

dpulls bot commented Jun 20, 2023

🎉 All dependencies have been resolved !

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

Upgrade logr, client-go and controller-runtime to newer versions which
include various bug fixes. Align code with respect to changes in those
libraries.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
@mergify
Copy link

mergify bot commented Jun 20, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 1e1e9d7 into samba-in-kubernetes:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-review This PR deserves a look
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants