Rename vault_a_p_i.ts to vault_API.ts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambacha
pushed a commit
that referenced
this pull request
Feb 19, 2021
* fix: too few shares are burned in case of loss w/ adjusted withdrawal Audit Response #2 - 5.1 * fix: check loss protection after adjusting for withdrawal capacity Audit Response #2 - 5.2 * docs: clarify documentation around revoking during emergency exit mode * fix: make expected return 0 if strategy is declaring itself inactive Audit Response #2 - 8.4 * fix: use strategy's lastReport value on migration, not block.timestamp Audit Reponse #2 - 8.5 * fix: increase precision on price calc by 3 places Audit Reponse #2 - 8.7 * refactor: small updates to comments and StrategyAPI functions Audit Response #2 - 5.5 * refactor: improve the accuracy of `expectedReturn` Audit Reponse #2 - 5.6 * docs: clarified requirement for Emergency Shutdown * docs: updated requirement Audit Reponse #2 - 5.12 * fix: add reentrancy guard (using same key as "withdraw") to "deposit" Audit Reponse #2 - 5.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.