Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup downgrades from typescript@latest to typescript@4.9.5 #827

Closed
hlovdal opened this issue Sep 28, 2023 · 1 comment
Closed

Setup downgrades from typescript@latest to typescript@4.9.5 #827

hlovdal opened this issue Sep 28, 2023 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@hlovdal
Copy link

hlovdal commented Sep 28, 2023

Question

Yesterday I ran setup

$ npx typia setup
----------------------------------------
 Typia Setup Wizard
----------------------------------------
? Package Manager npm

npm install --save-dev ts-patch@latest
npm install --save-dev ts-node@latest
npm install --save-dev typescript@latest
npm run postinstall
$

and everything was like expected. Today I ran setup again (to regenerate package-lock.json in an interactive rebase)

$ npx typia setup
Need to install the following packages:
  typia@5.1.3
Ok to proceed? (y) y
----------------------------------------
 Typia Setup Wizard
----------------------------------------
? Package Manager npm

npm install --save-dev ts-patch@latest
npm install --save-dev ts-node@latest
npm install --save-dev typescript@4.9.5
npm run postinstall

and suddenly the typescript version is downgraded. Is this expected?

Looking into all commits (git reflog -p -G typia -- package.json | grep typia | sort -u, same for package-lock.json), the version installed has always been 5.1.3, so it is not that I used to have 5.0.5 and then updated.

And since currently there are no commits present after the 5.1.3 release (which was done earlier yesterday) there are no logical explanation for the difference in behaviour.

@samchon
Copy link
Owner

samchon commented Sep 29, 2023

It is because you run the setup command without installing typia.

By the way, I also need to update the setup wizard, because typescript 4.9.5 is no more required, and ro prevent special bug like your case.

@samchon samchon self-assigned this Sep 29, 2023
@samchon samchon added the question Further information is requested label Sep 29, 2023
samchon added a commit that referenced this issue Sep 29, 2023
Fix #827 - change setup wizard logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants