For TypeScript v5.2 patch #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```typescript
type Intersection = { x: number } & Record<string | object | symbol, string>;
```
When intersection type with static object and dynamic object with `symbol` typed key comes, there had not been any problem until `TypeScript@5.1`. However, after `TypeScript@5.2` patch, it became an error in `typia`. I think TypeScript may changed internal logic of compiler.
Anyway, I fixed that bug and during the implementation, I found another type of bug. When above `Intersection` type comes, the property `x` must not be doubly checked by validation function of typia like `assert<T>()`. However, `typia` had done it, and I fixed that bug, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When intersection type with static object and dynamic object with
symboltyped key comes, there had not been any problem untilTypeScript@5.1. However, afterTypeScript@5.2patch, it became an error intypia. I think TypeScript may changed internal logic of compiler.Anyway, I fixed that bug and during the implementation, I found another type of bug. When above
Intersectiontype comes, the propertyxmust not be doubly checked by validation function of typia likeassert<T>(). However,typiahad done it, and I fixed that bug, too.