Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .tsx and Svelte files #816

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Support .tsx and Svelte files #816

merged 1 commit into from
Sep 21, 2023

Conversation

tsengia
Copy link
Contributor

@tsengia tsengia commented Sep 21, 2023

This PR aims to help solve issue #812 by adding a helper function to TypiaProgrammer.ts so that it checks for more file extensions other than .ts such as .tsx and .svelte.

TODO: Write and run tests for this.

@samchon samchon self-assigned this Sep 21, 2023
@samchon samchon self-requested a review September 21, 2023 03:48
@samchon samchon added the enhancement New feature or request label Sep 21, 2023
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will publish it soon.

@samchon samchon marked this pull request as ready for review September 21, 2023 03:53
@samchon samchon changed the base branch from master to features/svelte September 21, 2023 03:55
@samchon samchon merged commit 7dc1c84 into samchon:features/svelte Sep 21, 2023
1 check passed
@samchon
Copy link
Owner

samchon commented Sep 21, 2023

Not working on *.svelte file, but *.tsx is working well. I'll publish it now.

samchon added a commit that referenced this pull request Sep 21, 2023
@tsengia had tried to support both `tsx` and `svelte` files in the generation mode, but `svelte` does not work. Therefore, publish the new patch version only with `tsx` supporting.
samchon added a commit that referenced this pull request Sep 21, 2023
Complement #816 - support `*.tsx` files' generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants