Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @sinclair/typebox to devDependencies #832

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

techvlad
Copy link
Contributor

@techvlad techvlad commented Oct 4, 2023

When I'm trying to initialise project by using pnpm typebox dependency is missing due to strictness in pnpm.

This PR adds @sinclair/typebox to devDependencies

Before submitting a Pull Request, please test your code.

If you created a new feature, then create the unit test function, too.

# COMPILE
npm run build

# RE-WRITE TEST PROGRAMS IF REQUIRED
npm run test:template

# BUILD TEST PROGRAM
npm run build:test

# DO TEST
npm run test

Learn more about the CONTRIBUTING

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question that, why are you installing this repository through pnpm?

It is okay to installing typia on your project through pnpm, but this repository is designed to using the pure npm.

@samchon samchon merged commit 4172c5a into samchon:master Oct 5, 2023
1 check passed
@techvlad
Copy link
Contributor Author

techvlad commented Oct 5, 2023

I have a question that, why are you installing this repository through pnpm?

I prefer to use pnpm for all projects that I'm trying contribute. In typia repository I didn't found any lock file - so I decided to try pnpm

@samchon
Copy link
Owner

samchon commented Oct 5, 2023

Oops, I've missed package-lock.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants