Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #842 - exact description comment tracing. #843

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Oct 12, 2023

When object alias type comes, typia had failed to catch its description comment and comment tags. This PR fixes such long time bug.

As the description comment is not important feature in typia, nobody had identified it until @jakubpavlicko22 says.

// POSSIBLE TO CATCH
/**
 * Some description.
 *
 * @title something
 */
interface Interface {
    value: number;
}

// WAS NOT POSSIBLE
/**
 * Some description.
 *
 * @title something
 */
interface Type {
    value: number;
}

samchon and others added 12 commits October 6, 2023 23:56
  - `camel`
  - `pascal`
  - `snake`

Implemented everything, but fixing some bugs.
New module `notations`, the naming convention converters
Added version number on the right result viewer.
Close #838 - show typia version on playground.
To support `yarn berry` which had banned `npm prepare` script, I'd changed setup wizard of `typia` to define `npm postinstall` script instead.

By the way, unlike the `npm prepare` script which works on only in the local drive and does not work when be installed from remote `npm`, `npm postinstall` script is working even when installing from the remote `npm`. Therefore, when publishing an `npm` module which has installed `tyipa` through setup wizard, it enforces users of derived libraries to run the `npm postinstall` command that requires `ts-patch` module.

To fix this crazy bug, I've decided to ban `yarn berry` on the setup wizard. From now on, when you run the `npx typia setup` command, it will print a text that "yarn berry is not supported". If you still want to utilize the `yarn berry`, configure it manually by yourself please.
Ban `yarn berry` on setup wizard.
When object alias type comes, `typia` had failed to catch its description comment and comment tags. This PR fixes such long time bug.

As the description comment is not important feature in `typia`, nobody had identified it until @jakubpavlicko22 says.
@samchon samchon added bug Something isn't working enhancement New feature or request labels Oct 12, 2023
@samchon samchon self-assigned this Oct 12, 2023
@samchon samchon changed the base branch from master to v5.2 October 12, 2023 10:26
@samchon samchon merged commit 7b6d0f9 into v5.2 Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant