Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature psalm static analysis #76

Merged
merged 7 commits into from
Jul 2, 2021
Merged

Conversation

DavidGoodwin
Copy link
Contributor

add psalm static analysis support

src/Writer/PlainFileWriter.php Outdated Show resolved Hide resolved
@@ -22,7 +22,8 @@
"ext-xmlwriter": "*"
},
"require-dev": {
"phpunit/phpunit": "~7.1.5"
"phpunit/phpunit": "~7.1.5",
"vimeo/psalm": "*"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to specify version using SemVer here.

src/Writer/TempFileGZIPWriter.php Outdated Show resolved Hide resolved
@DavidGoodwin

This comment has been minimized.

@samdark
Copy link
Owner

samdark commented Jul 2, 2021

@DavidGoodwin is that possible to suppress it?

@samdark samdark merged commit c59aa87 into samdark:3.0.0 Jul 2, 2021
@samdark
Copy link
Owner

samdark commented Jul 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants