Add logger level configuration support #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcormier
reviewed
Apr 3, 2024
assets/runtime/functions
Outdated
| echo "config.action_controller.perform_caching = true" | ||
| echo "config.cache_classes = true" | ||
| echo "config.cache_store = :mem_cache_store, ${MEMCACHE_HOST}:${MEMCACHE_PORT}" | ||
| } >> "${REDMINE_MEMCACHED_CONFIG}" |
There was a problem hiding this comment.
Since this file is pulling double duty, can we rename REDMINE_MEMCACHED_CONFIG to REDMINE_ADDITIONAL_CONFIG
jcormier
reviewed
Apr 3, 2024
assets/runtime/functions
Outdated
| fi | ||
| } | ||
|
|
||
| redmine_configure_logger() { | ||
| echo "Configuring redmine::logger..." | ||
| echo "config.log_level = :${LOGGER_LEVEL:-info}" >> "${REDMINE_MEMCACHED_CONFIG}" |
There was a problem hiding this comment.
Also put the LOGGER_LEVEL default in env-defaults so its consistent with the other settings.
siberianlove
force-pushed
the
feature-configure-logger
branch
from
ad8d4e2
to
1038183
Compare
|
Thanks |
vchelban
reviewed
Apr 11, 2024
| echo "config.gem 'dalli'" | ||
| echo "config.action_controller.perform_caching = true" | ||
| echo "config.cache_classes = true" | ||
| echo "config.cache_store = :mem_cache_store, ${MEMCACHE_HOST}:${MEMCACHE_PORT}" |
There was a problem hiding this comment.
There is a regression in this line - unquoted string in config file throws error:
bundler: failed to load command: unicorn_rails (/home/redmine/redmine/vendor/bundle/ruby/3.2.0/bin/unicorn_rails)
/home/redmine/redmine/config/application.rb:97:in `instance_eval': (eval):14: syntax error, unexpected label (SyntaxError)
... = :mem_cache_store, memcached:11211
... ^~~~~~~~~~
There was a problem hiding this comment.
Thanks I'll get that fixed
There was a problem hiding this comment.
pushed commit to master branch, can you test and let me know before I push a new tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue: #140
When my redmine log storage was low i was looking for log rotation solution for my redmine instance and discovered that it has one out of the box: https://github.com/search?q=repo%3Asameersbn%2Fdocker-redmine%20logrotate&type=code
It's just my instance generated so much info logs by default. So it'l be great if administrators can configure amount of generated logs but in this repo i didn't found any solution for configuring logger level so i implemented it.
Tested on my instance.
Thx for the great repo by the way! When i discovered this repo it became a lot easier to administrate redmine.