Optimize Thread Usage while Loading Resources #1923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the KV Resource Store used it's thread pool for both loading and parsing/conforming the resources. However loading is I/O but parsing/conforming is CPU bound. So it is better to use the KV Resource Store Executor only for the loading, the I/O part.
With this change the KV Resource Store uses do-async to change to a common ForkJoinPool thread. This change has also the advantage that functions that are applied after the returned future do not have to change the thread pool because the futures are already on the common ForkJoinPool.
Removed all pool switching async functions. Tested the thread pool used.