Only report supported hvac_modes and fan_modes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates climate.py to report the capabilities reported by the Smartthinq model information. Our LP1419IVSM only supports `cool`, `fan_only` and `dry` `hvac_modes`, and the presence of `auto` would cause hass-smartthinq to set the temperature to the minimum whenever it's activated. This updates it to filter the `hvac_modes` to only those which are listed in the device's SupportOpMode list, and to filter `fan_modes` to only those listed in the device's SupportWindStrength list.
sampsyo
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates climate.py to report the capabilities reported by the Smartthinq model information.
Our LP1419IVSM only supports
cool,fan_onlyanddryhvac_modes, and the presence ofautowould cause hass-smartthinq to set the temperature to the minimum whenever it's activated.This updates it to filter the
hvac_modesto only those which are listed in the device's SupportOpMode list, and to filterfan_modesto only those listed in the device's SupportWindStrength list.