Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @types/chrome in templates to 0.0.263 #44

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

keyding
Copy link
Contributor

@keyding keyding commented Mar 31, 2024

Prior to version 0.0.254, the type of ManifestBass["author"] in @types/chrome was as follows:

// ...

export interface ManifestBase {
    // Required
    manifest_version: number;
    name: string;
    version: string;

    // Recommended
    default_locale?: string | undefined;
    description?: string | undefined;
    icons?: ManifestIcons | undefined;

    // Optional
    author?: string | undefined

    // ...
}

After version 0.0.254(As of now, the latest version is 0.0.263), the type of ManifestBass["author"] in @types/chrome is as follows:

//  ...

export interface ManifestBase {
    // Required
    manifest_version: number;
    name: string;
    version: string;

    // Recommended
    default_locale?: string | undefined;
    description?: string | undefined;
    icons?: ManifestIcons | undefined;

    // Optional
    author?: {
        email: string;
    } | undefine

    // ...
}

@samrum
Copy link
Owner

samrum commented Apr 4, 2024

Appreciate the PR!
Rather than add dev@rubenmedina.com, can you just remove the author fields everywhere? It's optional so there's not really any reason to set it in the templates at all really.

@keyding
Copy link
Contributor Author

keyding commented Apr 4, 2024

Appreciate the PR! Rather than add dev@rubenmedina.com, can you just remove the author fields everywhere? It's optional so there's not really any reason to set it in the templates at all really.

Thanks for the recognition!
I think you are right and I have made the changes.

@samrum samrum merged commit 0f1b364 into samrum:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants