Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case-insensitive upload conflict detection on case-insensitive file systems #882

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

samschott
Copy link
Owner

This prevents us from doing some additional renaming and reindexing work where not required. This work may occasionally raise unexpected errors, see for example #878.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #882 (b752d10) into main (73d782f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   78.66%   78.59%   -0.08%     
==========================================
  Files          42       42              
  Lines        7501     7546      +45     
==========================================
+ Hits         5901     5931      +30     
- Misses       1600     1615      +15     
Flag Coverage Δ
pytest 78.59% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/maestral/sync.py 84.68% <100.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samschott samschott merged commit e7a5d74 into main Apr 19, 2023
@samschott samschott deleted the case-normalised-compare branch April 19, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant