Fix to DORA call (#470)

samsmithnz · Jun 15, 2023 · a0cc310 · a0cc310
1 parent ae68b8e
commit a0cc310
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 20 deletions.
diff --git a/src/RepoGovernance.Core/APIAccess/DevOpsMetricServiceApi.cs b/src/RepoGovernance.Core/APIAccess/DevOpsMetricServiceApi.cs
@@ -19,7 +19,7 @@ public DevOpsMetricServiceApi(string devOpsServiceURL)
             try
             {
                 // api/DORASummary/GetDORASummaryItems?owner=samsmithnz&repository=DevOpsMetrics
-                string url = $"/api/DORASummary/GetDORASummaryItem?owner={owner}&project=&repository={repo}";
+                string url = $"/api/DORASummary/GetDORASummaryItem?owner={owner}&project=&repo={repo}";
                 return await BaseApi.GetResponse<DORASummaryItem>(Client, url);
             }
             catch (Exception ex)

diff --git a/src/RepoGovernance.Core/SummaryItemsDA.cs b/src/RepoGovernance.Core/SummaryItemsDA.cs
@@ -80,7 +80,6 @@ public static async Task<int> UpdateSummaryItem(string? clientId,
             string? devOpsServiceURL,
             string user,
             string owner,
-            string project,
             string repo)
         {
             int itemsUpdated = 0;
@@ -282,19 +281,6 @@ public static async Task<int> UpdateSummaryItem(string? clientId,
                     {
                         summaryItem.DORASummary = dORASummaryItem;
                     }
-                    else
-                    {
-                        //Initialize an empty DORA summary item
-                        dORASummaryItem = new(owner, project, repo)
-                        {
-                            DeploymentFrequency = 0,
-                            LeadTimeForChanges = 0,
-                            MeanTimeToRestore = 0,
-                            ChangeFailureRate = -1, //change failure rate is a percentage, so -1 is a good default value
-                            LastUpdatedMessage = "DORA statistics for this project doesn't exist"
-                        };
-                        summaryItem.DORASummary = dORASummaryItem;
-                    }
                 }
 
                 //Get the Release info

diff --git a/src/RepoGovernance.Function/ProcessItemFromQueueFunction.cs b/src/RepoGovernance.Function/ProcessItemFromQueueFunction.cs
@@ -52,7 +52,7 @@ public static async Task Run([QueueTrigger("summaryqueue", Connection = "AzureWe
                 Configuration["GitHubClientSecret"],
                 Configuration["SummaryQueueConnection"],
                 Configuration["DevOpsServiceURL"],
-                user, owner, project, repo);
+                user, owner, repo);
             if (itemsUpdated > 0)
             {
                 log.LogInformation($"C# Queue trigger function completed updating {itemsUpdated} items at: {DateTime.Now}");

diff --git a/src/RepoGovernance.Service/Controllers/SummaryItemsController.cs b/src/RepoGovernance.Service/Controllers/SummaryItemsController.cs
@@ -29,14 +29,14 @@ public List<UserOwnerRepo> GetRepos(string owner)
         /// <param name="repo">the repository being updated</param>
         /// <returns></returns>
         [HttpGet("UpdateSummaryItem")]
-        public async Task<int> UpdateSummaryItem(string user, string owner,string project, string repo)
+        public async Task<int> UpdateSummaryItem(string user, string owner, string repo)
         {
             return await SummaryItemsDA.UpdateSummaryItem(
                Configuration["AppSettings:GitHubClientId"],
                Configuration["AppSettings:GitHubClientSecret"],
                Configuration["AppSettings:CosmosDBConnectionString"],//Configuration["AppSettings:StorageConnectionString"],
                Configuration["AppSettings:DevOpsServiceURL"],
-               user, owner, project, repo);
+               user, owner, repo);
         }
 
         /// <summary>

diff --git a/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs b/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs
@@ -19,11 +19,10 @@ public async Task UpdateRepoGovernanceSummaryItemTest()
         //Arrange
         string user = "samsmithnz";
         string owner = "samsmithnz";
-        string project = null;
         string repo = "Sams2048";
 
         //Act - runs a repo in about 4s
-        int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem(GitHubId, GitHubSecret, AzureStorageConnectionString, DevOpsServiceURL, user, owner, project, repo);
+        int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem(GitHubId, GitHubSecret, AzureStorageConnectionString, DevOpsServiceURL, user, owner, repo);
 
         //Assert
         Assert.AreEqual(1, itemsUpdated);