Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PM tag to @RG header #16

Closed
keiranmraine opened this issue Jan 29, 2014 · 6 comments
Closed

Add PM tag to @RG header #16

keiranmraine opened this issue Jan 29, 2014 · 6 comments
Labels

Comments

@keiranmraine
Copy link

Hi,

As PL is a restricted list could PM, 'Platform Model', be added to the RG header definition? This would be an unrestricted text field allowing for more detailed information about the machine generating the data.

Regards,
Keiran

@tfenne
Copy link
Member

tfenne commented Jan 29, 2014

I think this is a good idea. For the longest time we've all been writing PL:illumina for the various Illumina instruments. It's likely that at least with the new chemistry on the NextSeq that we'll want to be able to identify NextSeq 2-color chemistry data vs. SBS 4-color. And with so many tools relying on PL I'm hesitant to change the value there.

-t

On Jan 29, 2014, at 3:46 AM, Keiran Raine notifications@github.com wrote:

Hi,

As PL is a restricted list could PM, 'Platform Model', be added to the RG header definition? This would be an unrestricted text field allowing for more detailed information about the machine generating the data.

Regards,
Keiran


Reply to this email directly or view it on GitHub.

@keiranmraine
Copy link
Author

Any chance this will happen? I notice that there has been a new spec version since this request was created.

@jmarshall
Copy link
Member

Since this tag was suggested, there's been an optional alignment aux tag added and a small error corrected. So there hasn't really been a whole new spec version released; it's just that now that the infrastructure is in order, it's very easy to regenerate the PDFs on the website so we do so after each little commit.

Would you like to propose some text describing PM, suitable for the table in §1.3?

@keiranmraine
Copy link
Author

Thanks for the clarification. How about (inserted between PL and PU):

Platform Model: more detailed description of platform, e.g. 'HiSeq 2500'. Field is not controlled, however appropriate PL should be specified when using this tag.

@tfenne
Copy link
Member

tfenne commented Apr 2, 2014

Wouldn't that be "Platform Model" not Unit?
-t

On Apr 2, 2014, at 5:59 AM, Keiran Raine notifications@github.com wrote:

Thanks for the clarification. How about (inserted between PL and PU):

Platform Unit: more detailed description of platform, e.g. 'HiSeq 2500'. Field is not controlled, however appropriate PL should be specified when using this tag.


Reply to this email directly or view it on GitHub.

@keiranmraine
Copy link
Author

Sorry yes, correcting now

@jmarshall jmarshall added the sam label May 19, 2014
jmarshall added a commit that referenced this issue Mar 3, 2015
Reinstate the previously-specified @HD-GO tag.  Fixes #15.
Add ONT (Oxford Nanopore) as a valid value for @RG-PL.  Fixes #39.
Add new free-form @RG-PM tag to allow more details about the platform
to be given, e.g., machine models such as 'HiSeq 2500'.  Fixes #16.
nh13 pushed a commit to samtools/htsjdk that referenced this issue Mar 4, 2015
nh13 pushed a commit to samtools/htsjdk that referenced this issue Mar 4, 2015
nh13 pushed a commit to samtools/htsjdk that referenced this issue Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants