Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving HttpUtilsTest to externalApi test task #1289

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

lbergelson
Copy link
Member

  • HttpUtilsTest is flakey because it connects to remote web servers.
    Moved it to the testExternalAPIs test task
  • changed a broken link so that the tests pass again

Description

Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

* HttpUtilsTest is flakey because it connects to remote web servers.
Moved it to the testExternalAPIs test task
* changed a broken link so that the tests pass again
@lbergelson
Copy link
Member Author

fixes #1287

@codecov-io
Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #1289 into master will increase coverage by 0.006%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             master     #1289       +/-   ##
==============================================
+ Coverage     67.49%   67.496%   +0.006%     
  Complexity     8150      8150               
==============================================
  Files           558       558               
  Lines         33365     33365               
  Branches       5608      5608               
==============================================
+ Hits          22518     22520        +2     
+ Misses         8658      8657        -1     
+ Partials       2189      2188        -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/samtools/util/HttpUtils.java 32.258% <0%> (-3.226%) 2% <0%> (-1%)
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

@yfarjoun
Copy link
Contributor

👍

@lbergelson lbergelson merged commit 38bfe65 into master Feb 18, 2019
@lbergelson lbergelson deleted the lb_change_broken_http_link branch February 18, 2019 02:39
@lbergelson
Copy link
Member Author

closes #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants