Some 32-bit fixes. #307
Closed
Some 32-bit fixes. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a couple compiler warnings with %ld vs size_t in printf. Fixed some overly large seeds to srand48. Changed some of the test SAM files to no longer use values greater than 2^31 (the limit required by the SAM specification).
|
It appears that most of these changes made their way in via commit a25229a. The missing ones are the size of the integer fields in the test data, which are still 32-bit unsigned instead of 31-bit max. However the SAM spec has since been updated to allow -2^31 to +2^32 so the max values now are valid (and the code has evidently been fixed to no longer produce failures). Therefore I'm closing this PR as already fixed (in 2014 no less!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple compiler warnings with %ld vs size_t in printf.
Fixed some overly large seeds to srand48.
Changed some of the test SAM files to no longer use values greater
than 2^31 (the limit required by the SAM specification).