This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 672
Add watcher type and the ability to remove watcher #110
Open
tevino
wants to merge
4
commits into
samuel:master
Choose a base branch
from
tevino:watcher
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevino
force-pushed
the
watcher
branch
9 times, most recently
from
April 11, 2016 09:51
1c5ed88
to
8d659ee
Compare
1. GetW ExistsW and ChildrenW return a *Watcher at the position of <-chan Event 2. The watcher could be removed(thus stopped) by Conn.RemoveWatcher(watcher) 3. The chan within a manually removed watcher will receive a special Event with ErrWatcherRemoved 4. WatchType and WatchPathType are exported
This was referenced Apr 11, 2016
Does this have any chance to be merged ? Is there something we can do to help get it merged ? |
samuel
force-pushed
the
master
branch
2 times, most recently
from
November 17, 2017 19:04
e51ba65
to
471cd4e
Compare
I used this library in my project, which caused a memory leak. The pprof file shows that addwatcher () takes up too much memory, so I want to use removeaddwatcher (). Have you actually used the PR code? My project is https://github.com/apache/dubbo-go,Looking forward to communicating with you |
I found the same problem from my source code
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
camlistore.org/pkg/throttle
is broken, switched togo4.org/net/throttle
GetW
ExistsW
andChildrenW
return a*Watcher
at the position of<-chan Event
watcher
could be removed(thus stopped) byConn.RemoveWatcher(watcher)
Event with
ErrWatcherRemoved
WatchType
andWatchPathType
are exported