Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build amd64 wheels for windows #74

Closed
Cranyozen opened this issue Dec 31, 2023 · 11 comments · Fixed by #79
Closed

Build amd64 wheels for windows #74

Cranyozen opened this issue Dec 31, 2023 · 11 comments · Fixed by #79

Comments

@Cranyozen
Copy link

This is a great project, I like it!
It would be nice if the releases can contain amd64 wheels for windows too.
Otherwise setuptools-rust must be present to continue the installation.

@samuelcolvin
Copy link
Owner

PR welcome to add it.

By the way, setuptools-rust isn't used, and maturin will be installed as a build requirement. The only external dependency is the rust toolchain.

@zerocewl
Copy link
Contributor

maybe fixed with #75 ?

the build wheels pipeline CI / build os is skipped, so i can't check which wheels are created

@zerocewl
Copy link
Contributor

zerocewl commented Jan 29, 2024

Seems to be fixed with #75, the pipeline contains now ...win_amd64.whl wheels again.

https://github.com/samuelcolvin/rtoml/actions/runs/7672121379/job/20911941988

  Compiling pyo3-build-config v0.20.0
   Compiling pyo3-ffi v0.20.0
   Compiling pyo3 v0.20.0
   Compiling rtoml v0.10.0 (D:\a\rtoml\rtoml)
    Finished release [optimized] target(s) in 14.90s
📦 Built wheel for CPython 3.11 to dist\rtoml-0.10.0-cp311-none-win_amd64.whl

Wheels should be part of the next release.

@mirrorcoloured
Copy link

mirrorcoloured commented Mar 28, 2024

Any updates on when this will be released? I'm stuck on a machine where I am unable to install rust.

LukasVik added a commit to hdl-registers/hdl-registers that referenced this issue Apr 2, 2024
Received private bug report that pip install of hdl-registers does not work on Windows.
Seems to be related to samuelcolvin/rtoml#74, since rtoml 0.9.0 worked for the reporter.
@LukasVik
Copy link

LukasVik commented Apr 2, 2024

I think it would be very good if there could be a new rtoml release made which includes the wheel for 64-bit Windows. I have started to get bug reports in https://github.com/hdl-registers/hdl-registers about pip install failing on Windows due to the dependency.

There are currently 322 projects on GitHub alone that use rtoml (https://github.com/samuelcolvin/rtoml/network/dependents). Releasing rtoml with Windows64 support reinstated would save a lot of confusion and bug reports.

LukasVik added a commit to hdl-registers/hdl-registers that referenced this issue Apr 3, 2024
Received private bug report that pip install of hdl-registers does not work on Windows.
Seems to be related to samuelcolvin/rtoml#74, since rtoml 0.9.0 worked for the reporter.
LukasVik added a commit to hdl-registers/hdl-registers that referenced this issue Apr 3, 2024
Received private bug report that pip install of hdl-registers does not work on Windows.
Seems to be related to samuelcolvin/rtoml#74, since rtoml 0.9.0 worked for the reporter.
@mtessmer
Copy link

I would like to second @LukasVik's request for another release to fix 64bit Windows installs. I am giving a tutorial on my package that depends on rtoml in a couple of weeks and it would be a lot better if my Windows users could install and update without issues or workarounds.

@mtessmer
Copy link

mtessmer commented May 1, 2024

I also want to point out that there is no earlier version of rtoml for Python 3.12 on Windows. This means Python 3.12 users on Windows can't install rtoml without installing rust and Visual C build tools. This is likely a large hurdle for beginners and so all 322 packages that depend on rtoml are effectively broken for new users on Windows.

@zerocewl
Copy link
Contributor

@samuelcolvin Can you please generate a new release? maybe a patch e.g. 0.10.1 is enough?

jeertmans added a commit to jeertmans/manim-slides that referenced this issue May 18, 2024
jeertmans added a commit to jeertmans/manim-slides that referenced this issue Jun 12, 2024
* chore(deps): pin `rtoml==0.9.0` on Windows

See #398 and samuelcolvin/rtoml#74.

* chore(ci): trying to fix on Python 3.12
@samuelcolvin
Copy link
Owner

Turns out this is not as simple as triggering a release, due to PyO3/maturin#2110. I think there's a workaround, see #79.

@samuelcolvin
Copy link
Owner

v0.11 is released, see https://pypi.org/project/rtoml/

@LukasVik
Copy link

Great, thank you so much @samuelcolvin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants