Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translator] Fixes an issue where the incorrect energy would be reported #89

Merged
merged 4 commits into from
Jun 22, 2020
Merged

[Translator] Fixes an issue where the incorrect energy would be reported #89

merged 4 commits into from
Jun 22, 2020

Conversation

louisleroy5
Copy link
Collaborator

  • Refactors tests

  • Corrects bug when looking for values in EP results

@louisleroy5 louisleroy5 added the enhancement Includes code that add's enhancements to existing archetypal functionalities label Jun 12, 2020
@louisleroy5 louisleroy5 self-assigned this Jun 12, 2020
samuelduchesne
samuelduchesne approved these changes Jun 22, 2020
View reviewed changes
Copy link
Owner

@samuelduchesne samuelduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@samuelduchesne samuelduchesne merged commit 2e593cf into samuelduchesne:develop Jun 22, 2020
@samuelduchesne samuelduchesne changed the title Debug translator [Translator] Fixes an issue where the incorrect energy would be reported Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelduchesne samuelduchesne samuelduchesne approved these changes

Assignees

@louisleroy5 louisleroy5

Labels
enhancement Includes code that add's enhancements to existing archetypal functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisleroy5 @samuelduchesne