Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #63

Merged
merged 1 commit into from
May 30, 2021
Merged

Misc doc changes #63

merged 1 commit into from
May 30, 2021

Conversation

kianmeng
Copy link
Contributor

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the main reference doc for this
Elixir library which leverage on latest features of ExDoc.

@coveralls
Copy link

coveralls commented May 25, 2021

Coverage Status

Coverage remained the same at 93.548% when pulling 0683412 on kianmeng:misc-doc-changes into 1db0607 on samueljseay:master.

Copy link
Collaborator

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Good stuff! 👍

@@ -35,8 +38,6 @@ defmodule Recaptcha.Mixfile do

defp description do
"""
A simple reCaptcha package for Elixir applications, provides verification
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you delete this? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Fixed.

mix.exs Outdated
{:dialyxir, "~> 0.5", only: [:dev]},
{:excoveralls, "~> 0.7.1", only: :test}
]
end

defp package do
[
description: "A simple reCaptcha package for Elixir applications, provides verification "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Maybe we can keep it as it was?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Maybe we can keep it as it was?

@sobolevn Done. Please check again. 😄

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the main reference doc for this
Elixir library which leverage on latest features of ExDoc.
Copy link
Collaborator

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit ca8dda7 into samueljseay:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants