Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Add Norwegian translations #85

Merged
merged 7 commits into from
May 3, 2020
Merged

Add Norwegian translations #85

merged 7 commits into from
May 3, 2020

Conversation

Z0ink5
Copy link
Contributor

@Z0ink5 Z0ink5 commented May 3, 2020

Translated by me

@Z0ink5
Copy link
Contributor Author

Z0ink5 commented May 3, 2020

Not sure why it failed, let me know if there's something I can fix in my pull request. :-)

@samuelmeuli
Copy link
Owner

There are some linting errors. Running yarn lint:css:fix && yarn lint:ts:fix && yarn format:fix should fix them for you. You can then commit the changes and push them to this PR's branch (master in your case), which will update the PR. No need to create a new one ;)

@Z0ink5
Copy link
Contributor Author

Z0ink5 commented May 3, 2020

There are some linting errors. Running yarn lint:css:fix && yarn lint:ts:fix && yarn format:fix should fix them for you. You can then commit the changes and push them to this PR's branch (master in your case), which will update the PR. No need to create a new one ;)

Thanks for that - I tried doing this in command line (running Windows 10 here) but I keep getting some errors about not matching any files etc. In which folder should I run this command? I used it on my clone of the Github-project itself.

New to pushing/pulling etc. :)

Img of output here: https://prnt.sc/saahps

@samuelmeuli
Copy link
Owner

samuelmeuli commented May 3, 2020

Looks like Windows doesn't like single quotes in NPM scripts... I'll fix it on my machine :)

@samuelmeuli samuelmeuli added the enhancement New feature or request label May 3, 2020
@samuelmeuli samuelmeuli changed the title Norwegian translation Add Norwegian translations May 3, 2020
@samuelmeuli samuelmeuli merged commit 9c45508 into samuelmeuli:master May 3, 2020
@samuelmeuli
Copy link
Owner

Thanks a lot for contributing! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants