Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bare string used as context key #59

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove bare string used as context key #59

merged 1 commit into from
Oct 16, 2020

Conversation

samuong
Copy link
Owner

@samuong samuong commented Oct 15, 2020

Also, use sync/atomic's AddUint64() to generate IDs, which is simpler
and avoids tying up a goroutine.

Fixes #17

@samuong
Remove bare string used as context key
b4c7475 
Also, use sync/atomic's AddUint64() to generate IDs, which is simpler
and avoids tying up a goroutine.

Fixes #17
camh-
camh- approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuong samuong merged commit d48c5a1 into master Oct 16, 2020
@samuong samuong deleted the context-id branch October 16, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camh- camh- camh- approved these changes

@marcelocantos marcelocantos Awaiting requested review from marcelocantos marcelocantos is a code owner

@juliaogris juliaogris Awaiting requested review from juliaogris juliaogris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove bare string used as context key.
2 participants
@samuong @camh-