-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename exported structs and functions #63
Conversation
Most of the changes here are simple renamings of types and functions. The only exception is that I've also merged the |
Could you create an issue for this an assign it the right number of story points. It's a little hard to track velocity and burndown without it. |
The purpose of this change is to reduce code duplication in `authenticator.go`. Previously, we needed to have two separate implementations of the NTLM handshake: one for CONNECT requests (which are written directly to a `net.Conn`) and another for all other requests (which are sent via an `http.Transport`). Now that we only need one (written against any `http.RoundTripper`), it will be simpler to implement additional authentication protocols in the future, such as Kerberos.
This reduces the "public API" of the `main` package to nothing. The next release of Alpaca will be v2.0.0, and any exported names will be made available in sub-packages with a minor version bump.
I guess I wasn't very clear in my original description, but my plan for the future is to split the |
I don't think you'll be breaking compatibility at all, since it is all currently in package main (not importable as i understand it). You could just move things bit by bit and as you do that, only export what needs to be exported as you make packages out of things, but up to you. |
f85c0d8
to
b2901dd
Compare
Ah, I hadn't ever actually thought about |
This reduces the "public API" of the
main
package to nothing. The nextrelease of Alpaca will be v2.0.0, and any exported names will be made
available in sub-packages with a minor version bump.