Try to determine PAC URL before downloading, rather than on startup #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuong
requested review from
camh-,
juliaogris and
marcelocantos
as code owners
samuong
force-pushed
the
use-operror-proxyconnect
branch
from
054263a
to
1dad3de
Compare
This allows Alpaca to detect changes in the system's PAC URL. Some VPN clients change the PAC URL to a locally-hosted file upon connection, so this needs to be checked whenever a network change is detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Alpaca to detect changes in the system's PAC URL. Some VPN
clients change the PAC URL to a locally-hosted file upon connection, so
this needs to be checked whenever a network change is detected.