Store derivatives on local file system instead of in repo. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
store_derivatives_on_disk
branch
from
2acc4d0
to
263f296
Compare
| @@ -13,10 +13,18 @@ def default_content_path | |||
| # Render the 404 page if the file doesn't exist. | |||
| # Otherwise renders the file. | |||
| def show | |||
| if file | |||
| unless file | |||
There was a problem hiding this comment.
Since you're already doing a type check on file in the case statement, can you move this into the case statement?
case file
when ActiveFedora::File
#...
when nil
#...
else
#...
end
|
Also, pls rebase! |
jcoyne
force-pushed
the
store_derivatives_on_disk
branch
from
263f296
to
ea90fa4
Compare
jcoyne
force-pushed
the
store_derivatives_on_disk
branch
from
ea90fa4
to
c0d8f85
Compare
rather than in Fedora. This is much faster than Fedora and avoids the problem of differentiating files when there are multiple access copies for different purposes (e.g. webm vs mp4, mp3 vs ogg) sharing a use predicate. Fixes #188
jcoyne
force-pushed
the
store_derivatives_on_disk
branch
from
c0d8f85
to
f462b3c
Compare
mjgiarlo
added a commit
that referenced
this pull request
Aug 24, 2015
Store derivatives on local file system instead of in repo.
jcoyne
added a commit
that referenced
this pull request
Aug 31, 2015
jcoyne
added a commit
that referenced
this pull request
Aug 31, 2015
kevinreiss
added a commit
that referenced
this pull request
Aug 31, 2015
Update Derivative spec to look for filesystem derivatives. Ref #194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188