Update Derivative spec to look for filesystem derivatives. Ref #194 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcoyne Do the derivatives get attached to the GenericFile in some way? Does the file point to the tmp area or something? |
2 tasks
|
@Cam156 no, there is no attachment. The way I'm looking at it is access derivatives don't belong in the repository because they can be regenerated and are not important to preserve. This is similar to how an image server can provide many different access versions of an image, which are not preserved. |
|
👍 to merging this. After that we can close out #46. |
kevinreiss
added a commit
that referenced
this pull request
Aug 31, 2015
Update Derivative spec to look for filesystem derivatives. Ref #194
|
@jcoyne I was wondering how the GF knew where the derivatives were located on disk? How do I know that one is there and exists if I want to display a thumbnail for instance. I have no problem with them living on disk instead of the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.