Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development server continuously hot reloading #122

Closed
wykhuh opened this issue Jul 27, 2023 · 3 comments · Fixed by #123
Closed

development server continuously hot reloading #122

wykhuh opened this issue Jul 27, 2023 · 3 comments · Fixed by #123

Comments

@wykhuh
Copy link
Contributor

wykhuh commented Jul 27, 2023

I cloned this repo, installed the packages, and started the development server. The server is continuously hot reloading, which causes the browser to also continuously reload.

If I change server.js .on("all" to .on("change" , then the server only reloads if I make a change to a file. Is there a reason to use .on("all" ?

@mathewjordan
Copy link
Member

@wykhuh You are correct. I don't think we need all.

Would you like me to make this change? Or will you put in a pull request?

Thank you for your interest in the project!

@wykhuh
Copy link
Contributor Author

wykhuh commented Jul 27, 2023

@mathewjordan I made a pull request. #123

I'm a developer for Collective Access, an open source cataloguing software used by museums, archives, and other groups. We rewriting our frontend app, and we are considering using Clover as our media viewer. Our users have IIIF images, video, audio, pdfs, and 3D models.

@mathewjordan mathewjordan linked a pull request Jul 27, 2023 that will close this issue
@mathewjordan
Copy link
Member

@mathewjordan I made a pull request. #123

I'm a developer for Collective Access, an open source cataloguing software used by museums, archives, and other groups. We rewriting our frontend app, and we are considering using Clover as our media viewer. Our users have IIIF images, video, audio, pdfs, and 3D models.

Thank you put the PR through @wykhuh. I really appreciate that.

If you're interested in implement Clover, you may want to know that I'm currently reorganizing Clover in advance of a version 2.x release. Clover IIIF will now be a suite of tools (with the Viewer just being one component) aimed at composing IIIF-centric user interfaces. If you'd like to take a look at that, please see docs in development here https://mathewjordan.github.io/clover-iiif-proto/ and the repo.

This will allow developers to quickly create interfaces like https://dc.library.northwestern.edu/items/8128dc86-9214-49a5-b40c-3b6416dfe740 using simple React components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants