Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error loading Fits MediaInfo dependency [Docker] #1520

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix error loading Fits MediaInfo dependency [Docker] #1520

merged 1 commit into from
Apr 19, 2018

Conversation

cldambrosio
Copy link
Contributor

Fixes #1274. referenced in #1301

RuntimeError: Unable to execute command "/opt/fits-1.0.5/fits.sh -i "/data/tmp/uploads/[etc]""
workers_1         | Exception in thread "main" edu.harvard.hul.ois.fits.exceptions.FitsToolException: 
Error loading native library for MediaInfo please check that fits_home is properly set

Change proposed in this pull request:

  • Add an environment variable pointing to FITS in docker-compose.yml

(CLA coming soon)
@samvera/hyrax-code-reviewers

mjgiarlo
mjgiarlo approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@cldambrosio
Copy link
Contributor Author

Do I need to look into the Travis CI fail so this can be merged?
The WebMock::NetConnectNotAllowedError seems unrelated- though I don't see a reported issue about it.

@cjcolvar cjcolvar merged commit 5393b41 into samvera:master Apr 19, 2018
@cldambrosio cldambrosio deleted the fits-error branch April 20, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cldambrosio @mjgiarlo @cjcolvar